Fix: Use RV's python version to build wheels #1009
Merged
+30
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Fix: Ensure python wheels are build with RV's python
Summarize your change.
When building wheels with python, CMake would use whichever Python version it found first, which was usually your system python. This poses a problem when its a different version that RV's python if there are any compiled libraries built (like with opentimelineio for example), since when you try to import the package it will look module built against the matching version of python.
To fix this issue, we will pass the python executable path to pip so we built it with RV's python. We will also use
--no-cache-dirto ensure we always built the package. Even if our python version does have a cached version available, we might be building it with different compilers or different versions of shared libraries, so let's not take that chance and just force pip to always build with RV's python. We will also use and--force-reinstallso we will always build OTIO when we build Python to ensure no underlying changes to RV's python make this issue reappear.Describe the reason for the change.
Build fix
Describe what you have tested and on which operating system.
Reproduced the issue on Mac OS, and verified the fix
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.